On Thu, 2018-06-28 at 11:34 +0200, Bastien Nocera wrote: > On Thu, 2018-06-28 at 10:22 +0200, Hans de Goede wrote: > > On 28-06-18 09:43, Michael Straube wrote: > > > ret = rtw_resume_process(padapter) > > > Is this a bug or is the if else construct just pointless? > > It probably is just pointless, my guess would be that once > > upon a time there was a difference in the paths and at some > > point that difference went away. > > Quite: > https://github.com/hadess/rtl8723bs/blob/7d36e26f78bbc709844c12ad0c62e3e8503fdbc5/os_dep/linux/sdio_intf.c#L1757 That #ifdef forest is/was quite unsightly. No wonder the realtek code is unmaintainable. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel