Re: [PATCH 2/2] staging: goldfish: Add goldfish sync driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

we wanted to include our changes into this year LTS.

> get the existing code cleaned up and out of the staging tree?

Is this drivers/staging/goldfish? After I deleted the nand driver I
see only goldfish_audio there.

> Also, this code causes a bunch of build warnings, I could not take it anyway.

Yes, I saw them.

Regards,
Roman.
On Thu, Jun 28, 2018 at 8:37 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Jun 27, 2018 at 02:50:52PM -0700, rkir@xxxxxxxxxx wrote:
> > From: Roman Kiryanov <rkir@xxxxxxxxxx>
> >
> > This is kernel driver for controlling the Goldfish sync
> > device on the host. It is used to maintain ordering
> > in critical OpenGL state changes while using
> > GPU emulation.
>
> Why are you adding new features and drivers and not spending the time to
> get the existing code cleaned up and out of the staging tree?  Please
> work on that, I don't want to keep taking new code without any time
> being spent on the existing stuff.
>
> Staging is not a dumping ground, work needs to be done on the code in it
> to get it out of the tree.  If that doesn't happen, I will remove it.
>
> Also, this code causes a bunch of build warnings, I could not take it
> anyway.  Please be more careful in the future.
>
> thanks,
>
> greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux