On Thu, Jun 28, 2018 at 01:32:41PM +0100, John Whitmore wrote: > On Thu, Jun 28, 2018 at 10:38:28AM +0300, Dan Carpenter wrote: > > On Wed, Jun 27, 2018 at 09:22:50PM +0100, John Whitmore wrote: > > > On Tue, Jun 26, 2018 at 11:56:24AM +0800, Greg KH wrote: > > > > On Sun, Jun 24, 2018 at 04:34:51PM +0100, John Whitmore wrote: > > > > > Changed a number of hard coded function names to use %s and __func__ > > > > > > > > > > Mailing list response suggest that there is a better method for debugging > > > > > using netdev_dbg(). I can't argue with that, but for the moment this change > > > > > will clear the checkpatch.pl Warning. > > > > > > > > > > Signed-off-by: John Whitmore <johnfwhitmore@xxxxxxxxx> > > > > > --- > > > > > drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++++++------ > > > > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > > > > > Did not apply :( > > > > > > No worries, can I just ask is that because it should be changed to use > > > netdev_dbg as was suggested? And should that be across the whole file? > > > > "Does not apply" means you save the raw email to email.txt then download > > the latest code from > > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next > > then `cat email.txt | git am` and it fails. > > > > Probably someone else's patch was merged ahead of yours. Fix it up and > > then resend. > > > > regards, > > dan carpenter > > Thank you for that. I read the sentence and filled in my own pronoun as there > wasn't one :( So I read it as "I did not apply" rather then "it did not > apply". That's great that 'it' did not apply, thought I'd done something > wrong. I'll have another crack at it later if I get a chance. Ick, sorry for being terse, my fault. greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
