Hi Roman, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.18-rc2 next-20180627] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/rkir-google-com/goldfish-Add-functions-to-simplify-goldfish-related-MMIO/20180628-055436 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/staging/goldfish/goldfish_sync_timeline.c:549:6: sparse: symbol 'run_command_locked' was not declared. Should it be static? >> drivers/staging/goldfish/goldfish_sync_timeline.c:622:6: sparse: symbol 'run_commands_locked' was not declared. Should it be static? drivers/staging/goldfish/goldfish_sync_timeline.c:855:5: sparse: symbol 'goldfish_sync_probe' was not declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel