Hi Jonathan, On Mon, 21 Feb 2011 16:10:14 +0000, Jonathan Cameron wrote: > On 02/15/11 20:49, Andrew Chew wrote: > >> As some of the platform not support irq_to_gpio, we pass gpio port > >> by platform data. > > > > Looks good to me. > > > > Signed-off-by: Andrew Chew <achew@xxxxxxxxxx> > Firstly, please cc linux-iio for patches effecting iio drivers. > > Hmm.. It's a bit of a pain that i2c devices don't take platform resources > or we could avoid doing this entirely. I have a vague recollection of this > being suggested in the past, but never happening (might have been for spi > rather than i2c though...) Jean, can you comment on this? I fear I don't have the slightest idea of what you're talking about. "Taking platform resources"? > Dmitry isn't going to want that header in the linux/input directory. And he would be right. Header files containing platform data structures for i2c device drivers go to include/linux/i2c. -- Jean Delvare _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel