Re: [PATCH 1/2] drivers/android: use SPDX license information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 22, 2018 at 08:27:24AM -0700, Todd Kjos wrote:
> Are you planning to add this for every source file in the kernel tree?

Someone has to, yes, we are planning on converting the whole tree, it's
about 1/3 done so far.

> Why this file?

Odds are checkpatch was run on this and it complained about it.

But:

> On Fri, Jun 22, 2018 at 2:25 AM Mawanda Henry
> <mawandahenrynaco@xxxxxxxxx> wrote:
> >
> > SPDX license helps developers and machines to know the right license
> > governing a file
> >
> > Signed-off-by: Mawanda Henry <mawandahenrynaco@xxxxxxxxx>
> > ---
> >  drivers/android/binder_alloc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/android/binder_alloc.c b/drivers/android/binder_alloc.c
> > index 2628806..84da232 100644
> > --- a/drivers/android/binder_alloc.c
> > +++ b/drivers/android/binder_alloc.c
> > @@ -1,3 +1,4 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later

When adding license information to a file, you had BETTER get it right.

This isn't the correct license for this file, sorry.  Do NOT do these
types of kernel changes unless you really understand license information
please.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux