Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Chris Opperman <eklikeroomys@xxxxxxxxx>
Subject: Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Fri, 22 Jun 2018 13:46:55 +0300
Cc: Kate Stewart <kstewart@xxxxxxxxxxxxxxxxxxx>, devel@xxxxxxxxxxxxxxxxxxxx, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Philippe Ombredanne <pombredanne@xxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>
In-reply-to: <20180621155352.GA20712@kerdev>
References: <1529514635-17948-1-git-send-email-eklikeroomys@gmail.com> <20180620200829.qm2zxeyyl5kqh6gu@mwanda> <20180621044252.GA19583@kerdev> <20180621082225.xuhqvm7bevbiuaso@mwanda> <20180621155352.GA20712@kerdev>
User-agent: NeoMutt/20170609 (1.8.3)

I liked the patch, but just go over the 80 character limit instead of
adding a "key" variable.  It's better that it generate a checkpatch
warning and forces someone to rename the variable...

regards,
dan carpenter


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Follow-Ups:
- Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key
  - From: Chris Opperman

References:
- [PATCH] staging: wlan-ng: improved readability of function prism2_add_key
  - From: Chris Opperman
- Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key
  - From: Dan Carpenter
- Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key
  - From: Chris Opperman
- Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key
  - From: Dan Carpenter
- Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key
  - From: Chris Opperman

Prev by Date: Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition
Next by Date: Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition
Previous by thread: Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key
Next by thread: Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add_key
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]