Hi Marcus, I'm currently working on the following TODO: 966 /* setup instance data*/ 967 instance->device = device; 968 instance->tx_cfg.bit_rate = 4711; 969 // TODO: fill instance->tx_cfg; If a user calls write() right after open()-ing an instance, the driver might try to setup the device with uninitialized garbage. In fact nothing really bad will happen because the rf69 interface abstraction will filter out wrong values, but this might be a confusing behavior for the user. What do you think about initializing instance->tx_cfg with the default values of the rf69 datasheet[0] ? Also, is there a specific reason why you chose 4711 as a default value for the bit rate ? I couldn't find it anywhere in the datasheet nor on the internet. Thanks ! Regards, Hugo [0] http://www.hoperf.com/upload/rf/RFM69CW-V1.1.pdf -- Hugo Lefeuvre (hle) | www.owl.eu.com 4096/ 9C4F C8BF A4B0 8FC5 48EB 56B8 1962 765B B9A8 BACA
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
