On Tue, Jun 19, 2018 at 9:18 AM, Quytelda Kahja <quytelda@xxxxxxxxx> wrote:
> I'm fairly sure this doesn't matter functionally (yet), but perhaps
> 'notify_timestamp' should be updated to an 's64' type since ktime_to_us()
> returns a signed type?
I think it's fine either way, ktime_t is only signed to deal with
differences between
times and the theoretical case of running with local time set to a
date before 1970
(which I'm sure fails for a number of other reasons), but boottime is guaranteed
to be positive as well as monotonically increasing, so an unsigned
type is fine here.
> That note aside, I think this is good.
> Reviewed-by: Quytelda Kahja <quytelda@xxxxxxxxxxx>
Thanks for taking a look!
Arnd
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
