Re: [PATCH v2] staging: mt7621-gpio: avoid use banks in device tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 18, 2018 at 10:53:31AM +0200, Greg KH wrote:
> On Mon, Jun 18, 2018 at 09:07:57AM +0200, Sergio Paracuellos wrote:
> > Banks shouldn't be defined in DT if number of resources
> > per bank is not variable. We actually know that this SoC
> > has three banks so take that into account in order to don't
> > overspecify the device tree. Device tree will only have one
> > node making it simple. Update device tree, binding doc and
> > code accordly.
> > 
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> > ---
> > Changes in v2:
> > Last patch in previous 'last cleanups' series is wrong passing
> > around a not initialized 'bank' to the 'mediatek_gpio_bank_probe'
> > function. Fix it here and because that patch is the last one in
> > the series just only resend this.
> 
> Ick, what am I supposed to do here?  I almost missed this :(
> 
> Please just resend a whole new versioned series, so that I don't mess
> things up.  You want to make it as _simple_ as possible for a brain-dead
> maintainer like me, otherwise I will get it wrong :)
> 
> I've dropped all of the mt7621-gpio patches from my queue now, please
> fix up and resend.

Ok, Greg, Sorry. Last version of those patches must be tested yet by
Neil and I realized that the last one in the series wasn't good, because
of that I only included this. I'll resend all v4 again including the modify
one.

> 
> thanks,
> 
> greg k-h

Best regards,
    Sergio Paracuellos
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux