I dropped lkml and akpm from the CC list. Hopefully no one minds too much. On Mon, Feb 21, 2011 at 02:52:48PM +0100, Timo von Holtz wrote: > @@ -67,8 +67,8 @@ static int dcon_init_xo_1_5(void) > unsigned int irq; > u_int8_t tmp; > struct pci_dev *pdev; > - > - > + > + Only one blank needed. > pdev = pci_get_device(PCI_VENDOR_ID_VIA, > PCI_DEVICE_ID_VIA_VX855, NULL); [snip] > @@ -103,18 +103,18 @@ static int dcon_init_xo_1_5(void) > > dcon_clear_irq(); > > - // set PMIO_Rx52[6] to enable SCI/SMI on gpio12 > + /* set PMIO_Rx52[6] to enable SCI/SMI on gpio12 */ > outb(inb(VX855_GPI_SCI_SMI)|BIT_GPIO12, VX855_GPI_SCI_SMI); > ^ this blank line isn't needed either. > } I only pointed out those things so you can check for it in the future. As far as I'm concerned this can be merged as is. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
