Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.17 next-20180615] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/linux-kernel-owner-vger-kernel-org/staging-rtl8192u-add-error-handling-for-usb_alloc_urb/20180616-012944 config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=xtensa All errors (new ones prefixed by >>): drivers/staging//rtl8192u/r8192U_core.c: In function 'rtl8192_usb_initendpoints': >> drivers/staging//rtl8192u/r8192U_core.c:1701:7: error: 'i' undeclared (first use in this function) for (i = 0; i < (MAX_RX_URB + 1); i++) ^ drivers/staging//rtl8192u/r8192U_core.c:1701:7: note: each undeclared identifier is reported only once for each function it appears in vim +/i +1701 drivers/staging//rtl8192u/r8192U_core.c 1688 1689 memset(priv->rx_urb, 0, sizeof(struct urb *) * MAX_RX_URB); 1690 priv->pp_rxskb = kcalloc(MAX_RX_URB, sizeof(struct sk_buff *), 1691 GFP_KERNEL); 1692 if (!priv->pp_rxskb) { 1693 DMESGE("Endpoint Alloc Failure"); 1694 goto out_release_mem; 1695 } 1696 1697 netdev_dbg(dev, "End of initendpoints\n"); 1698 return 0; 1699 1700 out_release_mem: > 1701 for (i = 0; i < (MAX_RX_URB + 1); i++) 1702 kfree(priv->rx_urb[i]); 1703 kfree(priv->rx_urb); 1704 priv->rx_urb = NULL; 1705 return -ENOMEM; 1706 } 1707 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel