Re: [PATCH 0/3] Staging: xgifb: Removes dead code and unused spinlock conditional compilation logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 21, 2011 at 10:09:04AM +0100, Javier Martinez Canillas wrote:
> [PATCH 1/3] Staging: xgifb: Removes dead code
> [PATCH 2/3] Staging: xgifb: Remove unused functions
> [PATCH 3/3] Staging: xgifb: Remove unused spinlock conditional compilation logic

Acked-by: Dan Carpenter <error27@xxxxxxxxx>

Looks good.  If you wanted to send some follow on patches, there are
some related things you could delete as well.

1)  All references to XGIfb_accel in drivers/staging/xgifb/XGI_accel.h
and drivers/staging/xgifb/XGI_main_26.c

2) spinlock_t lockaccel; from the video_info struct in 
drivers/staging/xgifb/XGIfb.h

3) The fbcon_XGI_sync() function doesn't do anything.  You can delete
all references to it.  Leave the ->fb_sync function pointer NULL.

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux