Re: [patch 1/2] staging: ath6kl: cleanup in SEND_FRAME ioctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 20, 2011 at 9:02 PM, Greg KH <greg@xxxxxxxxx> wrote:
> On Sun, Feb 20, 2011 at 08:45:44PM -0800, Luis R. Rodriguez wrote:
>> On Sun, Feb 20, 2011 at 8:14 PM, Greg KH <greg@xxxxxxxxx> wrote:
>> > On Sun, Feb 20, 2011 at 08:00:38PM -0800, Luis R. Rodriguez wrote:
>> >> On Sun, Feb 20, 2011 at 7:18 AM, Vipin Mehta <vmehta@xxxxxxxxxxx> wrote:
>> >> > On Sun, Feb 20, 2011 at 04:49:08AM -0800, Dan Carpenter wrote:
>> >> >> The original code was written in a funny way where every statement was
>> >> >> part of else if blocks. ÂI broke them up into separate statements by
>> >> >> adding breaks on failure conditions.
>> >> >>
>> >> >> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>> >>
>> >> Can you guys please join IRC? ...
>> >
>> > That is not a requirement for kernel development, sorry.
>>
>> No, but I'm not asking you, I'm asking Vipin and other developers,
>> using IRC is a good idea for internal coordination.
>
> I agree, but that wasn't what you said here :)
>
>> I see no way Vipin checking with Joe if he had his first set of
>> patches ready. We need to do major cleanup on the driver *now* and
>> these sort of miscommunication is just irritating. How do you
>> recommend we coordinate cleanup with random patches being ACKed in the
>> process without proper coordination?
>
> You get Joe and Vipin to work together and agree with what to do. ÂYou
> don't email 4 other people and 2 mailing lists with a request to join
> IRC :)

I've already told Vipin and friends about things, the purpose of
e-mailing other lists is to get people interested in sending patches
for ath6kl to help us coordinate better with them. If I only e-mail
private people I would have missed Dan Carpenter who sent these
patches out.

> It's not like we don't do this kind of things all the time, and have
> been for years, it just takes a willingness for the people involved to
> work together. ÂHopefully that is the case here.

The will is there, but:

1) Vipin told me he was going on vacation Friday, and yet he's ACKing
patches now
2) Who is the new maintainer for ath6kl ? I'm still waiting for the
respective patches from Vipin so I guess I'll do that now

  Luis
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux