xgifb staging driver uses a set of defines that hides the synchronization mechanism used to access critical sections. Also, the use of spinlocks can be disabled in compile time. Since the spinlocks ABI only are used in contexts were critical section exists (UP with preemption enabled and SMP machines), I think we should always have the spinlocks enabled and let the spinlock ABI choose to include the spinlocks or not. In the other hand if the driver doesn't need locking at all, then maybe we should just delete the spinlock logic. This patchset first replaces all the defines used with explicit definitions, then removes all the defines and the spinlocks optional compilation logic. The patchset is composed of the following patches: [PATCH 1/2] Staging: xgifb: Remove CRIT[FLAGS | BEGIN | END] defines usage [PATCH 2/2] Staging: xgifb: Removes CRIT[FLAGS | BEGIN | END] defines and conditional spinlock compilation logic _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
