On Mon, Jun 4, 2018 at 10:18 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> On Sun, Jan 01, 2017 at 01:00:59AM +0000, Abdul Rauf wrote:
> > Fix the following checks:
> > Alignment should match open parenthesis.
> >
> > Signed-off-by: Abdul Rauf <abdulraufmujahid@xxxxxxxxx>
> > ---
> > drivers/staging/fwserial/fwserial.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
> > index 41a49c8194e5..cb4e361fc545 100644
> > --- a/drivers/staging/fwserial/fwserial.c
> > +++ b/drivers/staging/fwserial/fwserial.c
> > @@ -1344,8 +1344,9 @@ static int fwtty_break_ctl(struct tty_struct *tty, int state)
> > if (state == -1) {
> > set_bit(STOP_TX, &port->flags);
> > ret = wait_event_interruptible_timeout(port->wait_tx,
> > - !test_bit(IN_TX, &port->flags),
> > - 10);
> > + !test_bit(IN_TX,
> > + &port->flags),
> > + 10);
>
> The original is basically fine... I don't necessarily see this as
> improving the readability. But anyway, if you really want to do this
> then the "10);" is indented way too far. It should be aligned with the
> '!' in "!test_bit(IN_TX,".
>
> regards,
> dan carpenter
>
Thanks for the feedback. Both you and Greg KH are right. This patch
was discarded because it doesn't improve readability.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
