Re: [PATCH] staging: rtl8192u: remove redundant variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 08, 2018 at 03:39:06PM +0800, Kenneth Lu wrote:
> @@ -1017,7 +1016,6 @@ static void rtl8192_hard_data_xmit(struct sk_buff *skb, struct net_device *dev,
>  	*(struct net_device **)(skb->cb) = dev;
>  	tcb_desc->bTxEnableFwCalcDur = 1;
>  	skb_push(skb, priv->ieee80211->tx_headroom);
> -	ret = rtl8192_tx(dev, skb);

This isn't right and you need to be a lot more careful.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux