Re: [PATCH 1/2] staging: mt7621-dts: Fix several dts warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 04 2018, Rosen Penev wrote:

> Node /cpus/cpu@0 has a unit name, but no reg property
> Node /cpus/cpu@1 has a unit name, but no reg property
> Node /cpuintc@0 has a unit name, but no reg property
> Node /cpuclock@0 has a unit name, but no reg property
> Node /sysclock@0 has a unit name, but no reg property
>
> I tried to match what is in mt7623.dtsi.
>
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>

Reviewed-by: NeilBrown <neil@xxxxxxxxxx>

Thanks,
NeilBrown

> ---
>  drivers/staging/mt7621-dts/mt7621.dtsi | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi b/drivers/staging/mt7621-dts/mt7621.dtsi
> index 240d396bbb89..5a94fcb96402 100644
> --- a/drivers/staging/mt7621-dts/mt7621.dtsi
> +++ b/drivers/staging/mt7621-dts/mt7621.dtsi
> @@ -6,16 +6,23 @@
>  	compatible = "mediatek,mt7621-soc";
>  
>  	cpus {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
>  		cpu@0 {
> +			device_type = "cpu";
>  			compatible = "mips,mips1004Kc";
> +			reg = <0x0>;
>  		};
>  
>  		cpu@1 {
> +			device_type = "cpu";
>  			compatible = "mips,mips1004Kc";
> +			reg = <0x1>;
>  		};
>  	};
>  
> -	cpuintc: cpuintc@0 {
> +	cpuintc: cpuintc {
>  		#address-cells = <0>;
>  		#interrupt-cells = <1>;
>  		interrupt-controller;
> @@ -26,7 +33,7 @@
>  		serial0 = &uartlite;
>  	};
>  
> -	cpuclock: cpuclock@0 {
> +	cpuclock: cpuclock {
>  		#clock-cells = <0>;
>  		compatible = "fixed-clock";
>  
> @@ -34,7 +41,7 @@
>  		clock-frequency = <880000000>;
>  	};
>  
> -	sysclock: sysclock@0 {
> +	sysclock: sysclock {
>  		#clock-cells = <0>;
>  		compatible = "fixed-clock";
>  
> -- 
> 2.17.1

Attachment: signature.asc
Description: PGP signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux