On Tue, May 29, 2018 at 10:21:48AM -0400, James Simmons wrote: > From: Amir Shehata <amir.shehata@xxxxxxxxx> > > This patch adds NUMA node support. Really? It looks like you just added an empty data structure pointer that doesn't really do anything at all. Where are you reading the host memory NUMA information from? And why would a filesystem care about this type of thing? Are you going to now mirror what the scheduler does with regards to NUMA topology issues? How are you going to handle things when the topology changes? What systems did you test this on? What performance improvements were seen? What downsides are there with all of this? I need a whole lot more information here... > NUMA node information is stored > in the CPT table. A NUMA node mask is maintained for the entire > table as well as for each CPT to track the NUMA nodes related to > each of the CPTs. Add new function cfs_cpt_of_node() which returns > the CPT of a particular NUMA node. This doesn't really seem to match up with the code changes from what I can tell... thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
