The following series performs last cleanups pointed out in this mail by NeilBrown: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-May/121282.html If this is ok and after testing this driver should be ready to go out of staging. Please, note that this has to eb applied after previous series which are before in this mail thread. Hope this helps. Best regards, Sergio Paracuellos Sergio Paracuellos (6): staging: mt7621-dts: fix property #interrupt-cells for the gpio node staging: mt7621-gpio: dt-bindings: update documentation for #interrupt-cells property staging: mt7621-gpio: change 'to_mediatek_gpio' to make just a one line return staging: mt7621-gpio: use GPIOF_DIR_OUT and GPIOF_DIR_IN macros instead of custom values staging: mt7621-gpio: change gc_map to don't use pointers staging: mt7621-gpio: reorder includes alphabetically drivers/staging/mt7621-dts/mt7621.dtsi | 2 +- drivers/staging/mt7621-gpio/gpio-mt7621.c | 38 +++++++++------------- .../staging/mt7621-gpio/mediatek,mt7621-gpio.txt | 10 ++++-- 3 files changed, 25 insertions(+), 25 deletions(-) -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel