Hi Florian, Florian Fainelli <f.fainelli@xxxxxxxxx> writes: > Andrew, Vivien, if the following hunks get applied are we possibly > breaking mv88e6xxx? This is the use case that is really missing IMHO at > the moment in DSA: we cannot control the VLAN membership and attributes > of the CPU port(s), so either we make it always tagged in every VLAN > (not great), or we introduce the ability to target the CPU port which is > what Petr's patches + mine do. Your change looks good to me. mv88e6xxx programs the DSA and CPU ports' membership as "unmodified" (i.e. "as-is", which is a Marvell feature), so that shouldn't change the current behavior. Thanks, Vivien _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel