On 05/24/2018 08:09 AM, Petr Machata wrote:
> In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap
> mirror"), mlxsw got support for offloading mirror-to-gretap such that
> the underlay packet path involves a bridge. In that case, the offload is
> also influenced by PVID setting of said bridge. However, changes to VLAN
> configuration of the bridge itself do not generate switchdev
> notifications, so there's no mechanism to prod mlxsw to update the
> offload when these settings change.
>
> In this patchset, the problem is resolved by distributing the switchdev
> notification SWITCHDEV_OBJ_ID_PORT_VLAN also for configuration changes
> on bridge VLANs. Since stacked devices distribute the notification to
> lower devices, such event eventually reaches the driver, which can
> determine whether it's a bridge or port VLAN by inspecting orig_dev.
>
> To keep things consistent, the newly-distributed notifications observe
> the same protocol as the existing ones: dual prepare/commit, with
> -EOPNOTSUPP indicating lack of support, even though there's currently
> nothing to prepare for and nothing to support. Correspondingly, all
> switchdev drivers have been updated to return -EOPNOTSUPP for bridge
> VLAN notifications.
This is great, see the other two emails about why I like it so much:
Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Tested-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Thanks!
>
> In patch #1, the code to send notifications for adding and deleting is
> factored out into two named functions.
>
> In patches #2-#5, respectively for mlxsw, rocker, DSA and DPAA2 ethsw,
> the new notifications (which are not enabled yet) are ignored to
> maintain the current behavior.
>
> In patch #6, the notification is actually enabled.
>
> In patch #7, mlxsw is changed to update offloads of mirror-to-gre also
> for bridge-related notifications.
>
> Petr Machata (7):
> net: bridge: Extract boilerplate around switchdev_port_obj_*()
> mlxsw: spectrum_switchdev: Ignore bridge VLAN events
> rocker: rocker_main: Ignore bridge VLAN events
> dsa: port: Ignore bridge VLAN events
> staging: fsl-dpaa2: ethsw: Ignore bridge VLAN events
> net: bridge: Notify about bridge VLANs
> mlxsw: spectrum_switchdev: Schedule respin during trans prepare
>
> .../ethernet/mellanox/mlxsw/spectrum_switchdev.c | 8 ++-
> drivers/net/ethernet/rocker/rocker_main.c | 6 +++
> drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 +++
> net/bridge/br_vlan.c | 58 ++++++++++++++--------
> net/dsa/port.c | 6 +++
> 5 files changed, 62 insertions(+), 22 deletions(-)
>
--
Florian
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
