Re: [PATCH2 1/3] staging: brcm80211: remove warning introduced by rfkill implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 18 Feb 2011 21:55:19 +0100, Greg KH <greg@xxxxxxxxx> wrote:

 static void wlc_radio_upd(struct wlc_info *wlc)
 {
+	if (wlc->pub->radio_disabled) {
+		wlc_radio_disable(wlc);
+	} else {
+		wlc_radio_enable(wlc);
+	}

You obviously didn't run this through checkpatch, which is sad, because
now you will have to send another patch to fix this up later.

Unless that's your plan all along...


It was not. Just falling back in 15 years coding style indoctrination ;-) Will create a patch for this.

Gr. AvS
--
"The most merciful thing in the world, I think, is the inability of the human
mind to correlate all its contents." - "The Call of Cthulhu"

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux