Re: [PATCH3 04/12] staging: brcm80211: remove usage of printf (macro) from driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 18 Feb 2011 21:47:36 +0100, Greg KH <greg@xxxxxxxxx> wrote:

On Thu, Feb 10, 2011 at 12:03:44PM +0100, Arend van Spriel wrote:
The driver contained several calls to printf which was mapped
to printk using a macro. These have been changed to explicit
call to printk or use an appropropriate macro.

I'll take this for now, but these really need to be converted to use the
proper network printk() macros, or dev_printk() and friends instead of
rolling "raw" printk messages with your own logging level controls.


Agree. We are already looking at those to replace our WL_level() macros.

thanks,

greg k-h


Gr. AvS
--
"The most merciful thing in the world, I think, is the inability of the human
mind to correlate all its contents." - "The Call of Cthulhu"

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux