On Fri, May 18, 2018 at 06:17:07PM +0100, John Whitmore wrote:
> Corrected coding style issue:
> ERROR: spaces required around that '==' etc. etc.
>
> Signed-off-by: John Whitmore <johnfwhitmore@xxxxxxxxx>
> ---
> .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 108 ++++++++++-----------
> 1 file changed, 54 insertions(+), 54 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> index efccfd85fe0e..780ef00f8806 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> @@ -60,8 +60,8 @@ void HTUpdateDefaultSetting(struct ieee80211_device *ieee)
> //printk("pHTinfo:%p, &pHTinfo:%p, mptr:%p, offsetof:%x\n", pHTInfo, &pHTInfo, __mptr, offsetof(struct ieee80211_device, pHTInfo));
> //printk("===>ieee:%p,\n", ieee);
> // ShortGI support
> - pHTInfo->bRegShortGI20MHz= 1;
> - pHTInfo->bRegShortGI40MHz= 1;
> + pHTInfo->bRegShortGI20MHz = 1;
> + pHTInfo->bRegShortGI40MHz = 1;
>
> // 40MHz channel support
> pHTInfo->bRegBW40MHz = 1;
> @@ -272,8 +272,8 @@ u16 HTHalfMcsToDataRate(struct ieee80211_device *ieee, u8 nMcsRate)
> u8 is40MHz;
> u8 isShortGI;
>
> - is40MHz = (IsHTHalfNmode40Bandwidth(ieee))?1:0;
> - isShortGI = (IsHTHalfNmodeSGI(ieee, is40MHz))? 1:0;
> + is40MHz = (IsHTHalfNmode40Bandwidth(ieee)) ? 1:0;
Why the odd spacing around '='?
> + isShortGI = (IsHTHalfNmodeSGI(ieee, is40MHz)) ? 1:0;
You fixed the space issue around '?', but not ':', which isn't good.
Again, fix it all up at once.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
