On Wed, May 16, 2018 at 11:24 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > I see goldfish_audio.c in drivers/staging/goldfish. There > > is arch/mips/configs/generic/board-ranchu.config referencing this driver > > (CONFIG_GOLDFISH_AUDIO=y). I believe we need to keep goldfish to keep this > > config. > Does anyone actually use that config? Is it a "real" device? We use this driver in our own defconfigs. If we upstream them, the driver will be referenced. > > I can move the goldfish folder to a more appropriate place and add more > > goldfish drivers there. Will drivers/goldfish work for you? > It has a long effort to be cleaned up properly before it can get out of > drivers/staging/, it's not a matter of just moving it to a new > directory. It is in staging for a good reason :) I can work on cleaning audio to move it out of staging if we need it. Is ok just to delete the nand driver for now? > Again, are these even needed now that the cuttlefish build target is > present? Who is even using these drivers? goldfish_audio is used in our local branches. > Why has no one worked on > cleaning up the upstream code in the past few years? I will be working on cleaning up them. Regards, Roman. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
