On Mon, May 14, 2018 at 04:02:33PM +0200, Sergio Paracuellos wrote: > This commit add missing dt bindings documentation for mt7621-gpio > driver. After this checkpatch script complain about this > issue dissapears. > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx> > --- > .../devicetree/bindings/gpio/mtk,mt7621-gpio.txt | 51 ++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/mtk,mt7621-gpio.txt > > diff --git a/Documentation/devicetree/bindings/gpio/mtk,mt7621-gpio.txt b/Documentation/devicetree/bindings/gpio/mtk,mt7621-gpio.txt > new file mode 100644 > index 0000000..5fe4bb5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/mtk,mt7621-gpio.txt > @@ -0,0 +1,51 @@ > +Mediatek SoC GPIO controller bindings > + > +The IP core used inside these SoCs has 3 banks of 32 GPIOs each. > +The registers of all the banks are interwoven inside one single IO range. > +We load one GPIO controller instance per bank. To make this possible > +we support 2 types of nodes. The parent node defines the memory I/O range and > +has 3 children each describing a single bank. > + > +Required properties for the top level node: > +- compatible: > + - "mtk,mt7621-gpio" for Mediatek controllers As stated in the previous review, "mtk" is not valid, please use "mediatek" like the rest of the kernel does :) thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
