Re: [PATCH] staging: speakup: Fix coding style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2018-05-13 at 11:38 +0200, Samuel Thibault wrote:
[]
> @@ -68,7 +68,7 @@ int spk_punc_level, spk_reading_punc;
>  char spk_str_caps_start[MAXVARLEN + 1] = "\0";
>  char spk_str_caps_stop[MAXVARLEN + 1] = "\0";
>  char spk_str_pause[MAXVARLEN + 1] = "\0";
> -bool spk_paused = 0;
> +bool spk_paused;
>  const struct st_bits_data spk_punc_info[] = {
>  	{"none", "", 0},
>  	{"some", "/$%&@", SOME},
> @@ -1782,8 +1782,7 @@ static void speakup_con_update(struct vc
>  		/* Speakup output, discard */
>  		return;
>  	speakup_date(vc);
> -	if (vc->vc_mode == KD_GRAPHICS && !spk_paused && spk_str_pause[0])
> -	{
> +	if (vc->vc_mode == KD_GRAPHICS && !spk_paused && spk_str_pause[0]) {
>  		synth_printf("%s", spk_str_pause);
>  		spk_paused = 1;

probably nice to change the assignments of
spk_paused to true&false too
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux