On Thu, May 10 2018, Justin Skists wrote: > Add a static prefix to the declaration for libcfs_dev. This would fix > the following sparse warning: > > drivers/staging/lustre/lnet/libcfs/module.c:317:19: warning: symbol > 'libcfs_dev' was not declared. Should it be static? Thanks - that was my fault. (b4ded66db93b) Reviewed-by: NeilBrown <neilb@xxxxxxxx> Thanks, NeilBrown > > Signed-off-by: Justin Skists <justin.skists@xxxxxxxxxxx> > --- > drivers/staging/lustre/lnet/libcfs/module.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/lustre/lnet/libcfs/module.c b/drivers/staging/lustre/lnet/libcfs/module.c > index ca942f474a55..e021e439f140 100644 > --- a/drivers/staging/lustre/lnet/libcfs/module.c > +++ b/drivers/staging/lustre/lnet/libcfs/module.c > @@ -314,7 +314,7 @@ static const struct file_operations libcfs_fops = { > .unlocked_ioctl = libcfs_psdev_ioctl, > }; > > -struct miscdevice libcfs_dev = { > +static struct miscdevice libcfs_dev = { > .minor = MISC_DYNAMIC_MINOR, > .name = "lnet", > .fops = &libcfs_fops, > -- > 2.17.0
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel