On Wed, May 09, 2018 at 04:09:21PM +0200, Christian Gromm wrote: > On 09.05.2018 15:19, Dan Carpenter wrote: > > On Tue, May 08, 2018 at 11:44:49AM +0200, Christian Gromm wrote: > > > This prohibits the allocation of the memory for the MBOs if only the > > > part of the MBOs, requested by the application, may be allocated. The > > > function arm_mbo_chain, if cannot allocate all requested MBO, frees all > > > prior allocated memory and returns 0. > > > > > > Signed-off-by: Andrey Shvetsov <andrey.shvetsov@xxxxxx> > > > Signed-off-by: Christian Gromm <christian.gromm@xxxxxxxxxxxxx> > > > > I don't understand how Andrey is involved with this code. Did he write > > it? Why isn't he on the CC list? > > Andrey and I are writing the code for this driver and our internal dev > process on Gitlab is based on reviews. > Which means that everything I push needs to be reviewed by Andrey and > vice versa before it gets merged to master. Then I have to do the > upstream work. > > I didn't put him on CC explicitly, because git-sendemail does it, > doesn't it? It didn't CC him so far as I can see... BCC? Signed-of-by basically means you handled the code but didn't secretly insert any of SCO's top secret UNIX code into the patch. It's sort of a legal thing. It sort of sounds like Andrey is reviewing your code? In that case, probably Reviewed-by is the correct tag. Normally the tags are sort of in chronoligical order. Reported-by: Sally Signed-off-by: Bob Reviewed-by: Mary Signed-off-by: Subsystem Maintainer So it always confuses me when the first person to Sign off isn't the author. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
