Re: [PATCH 30/30] staging: wilc1000: rename s8idxarray to avoid datatype in variable name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 07.05.2018 11:43, Ajay Singh wrote:
> Cleanup patch to have variable names as per linux coding style.
> 
> Signed-off-by: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx>
> ---
>  drivers/staging/wilc1000/host_interface.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index ad9270e..e27010c 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -1543,7 +1543,7 @@ static int handle_key(struct wilc_vif *vif, struct key_attr *hif_key)
>  	struct wid wid;
>  	struct wid wid_list[5];
>  	u8 *key_buf;
> -	s8 s8idxarray[1];
> +	s8 idxarray[1];
>  	struct host_if_drv *hif_drv = vif->hif_drv;
>  
>  	switch (hif_key->type) {
> @@ -1610,8 +1610,8 @@ static int handle_key(struct wilc_vif *vif, struct key_attr *hif_key)
>  			wid.id = (u16)WID_REMOVE_WEP_KEY;
>  			wid.type = WID_STR;
>  
> -			s8idxarray[0] = (s8)hif_key->attr.wep.index;
> -			wid.val = s8idxarray;
> +			idxarray[0] = (s8)hif_key->attr.wep.index;

I think you can get rid of idxarray at all.

> +			wid.val = idxarray;>  			wid.size = 1;
>  
>  			result = wilc_send_config_pkt(vif, SET_CFG,
> 
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux