RE: [PATCH] Drivers: hv: vmbus: enable VMBus protocol version 5.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
> Sent: Tuesday, May 8, 2018 15:45
> On Tue, 8 May 2018 22:26:21 +0000
> Dexuan Cui <decui@xxxxxxxxxxxxx> wrote:
> 
> > @@ -63,6 +63,9 @@ static __u32 vmbus_get_next_version(__u32
> current_version)
> >  	case (VERSION_WIN10):
> >  		return VERSION_WIN8_1;
> >
> > +	case (VERSION_WIN10_V5):
> > +		return VERSION_WIN10;
> > +
> >  	case (VERSION_WS2008):
> 
> In a future patch, we should get rid of the use of parenthesis on this switch
> statement.  Lots of other cleanup of this code is possible as well.

I agree.
We can make another patch to clean up this function. Maybe we should
replace the function with an array of versions.

Thanks,
-- Dexuan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux