On Wed, May 09 2018, Kamal Heib wrote:
> Quoted strings should not be split to help text grep in the source.
>
> Signed-off-by: Kamal Heib <kamalheib1@xxxxxxxxx>
> ---
> drivers/staging/mt7621-eth/mtk_eth_soc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth/mtk_eth_soc.c
> index 284585695869..bffa69a82b54 100644
> --- a/drivers/staging/mt7621-eth/mtk_eth_soc.c
> +++ b/drivers/staging/mt7621-eth/mtk_eth_soc.c
> @@ -1539,8 +1539,7 @@ static void mtk_tx_timeout(struct net_device *dev)
> if (eth->soc->dma_type & MTK_PDMA) {
> netif_info(eth, drv, dev, "pdma_cfg:%08x\n",
> mtk_reg_r32(eth, MTK_REG_PDMA_GLO_CFG));
> - netif_info(eth, drv, dev, "tx_ring=%d, "
> - "base=%08x, max=%u, ctx=%u, dtx=%u, fdx=%hu, next=%hu\n",
> + netif_info(eth, drv, dev, "tx_ring=%d, base=%08x, max=%u, ctx=%u, dtx=%u, fdx=%hu, next=%hu\n",=
Please make this
> + netif_info(eth, drv, dev,
> + "tx_ring=%d, base=%08x, max=%u, ctx=%u, dtx=%u, fdx=%hu, next=%hu\n",
When a string exceeds the 80-char point, it should be on a line by
itself if possible.
(same below)
Thanks,
NeilBrown
> 0, mtk_reg_r32(eth, MTK_REG_TX_BASE_PTR0),
> mtk_reg_r32(eth, MTK_REG_TX_MAX_CNT0),
> mtk_reg_r32(eth, MTK_REG_TX_CTX_IDX0),
> @@ -1551,8 +1550,7 @@ static void mtk_tx_timeout(struct net_device *dev)
> if (eth->soc->dma_type & MTK_QDMA) {
> netif_info(eth, drv, dev, "qdma_cfg:%08x\n",
> mtk_r32(eth, MTK_QDMA_GLO_CFG));
> - netif_info(eth, drv, dev, "tx_ring=%d, "
> - "ctx=%08x, dtx=%08x, crx=%08x, drx=%08x, free=%hu\n",
> + netif_info(eth, drv, dev, "tx_ring=%d, ctx=%08x, dtx=%08x, crx=%08x, drx=%08x, free=%hu\n",
> 0, mtk_r32(eth, MTK_QTX_CTX_PTR),
> mtk_r32(eth, MTK_QTX_DTX_PTR),
> mtk_r32(eth, MTK_QTX_CRX_PTR),
> --
> 2.14.3
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
