Re: [PATH V2 1/4] staging: mt7621-eth: Fix compilation error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 07 2018, Kamal Heib wrote:

> Fix the following comilation error by making sure that "phy_ring_head" is
> defined as "dma_addr_t" and change "phy_ring_tail" to match it as both
> should be "dma_addr_t".
>
> error: passing argument 3 of ‘dma_alloc_coherent’ from incompatible pointer type
>
> Signed-off-by: Kamal Heib <kamalheib1@xxxxxxxxx>

Reviewed-by: NeilBrown <neil@xxxxxxxxxx>

thanks,
NeilBrown


> ---
>  drivers/staging/mt7621-eth/mtk_eth_soc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/mt7621-eth/mtk_eth_soc.c b/drivers/staging/mt7621-eth/mtk_eth_soc.c
> index cbc7339843a5..c44a2f8a841c 100644
> --- a/drivers/staging/mt7621-eth/mtk_eth_soc.c
> +++ b/drivers/staging/mt7621-eth/mtk_eth_soc.c
> @@ -768,9 +768,8 @@ static int mtk_pdma_tx_map(struct sk_buff *skb, struct net_device *dev,
>  /* the qdma core needs scratch memory to be setup */
>  static int mtk_init_fq_dma(struct mtk_eth *eth)
>  {
> -	unsigned int phy_ring_head, phy_ring_tail;
> +	dma_addr_t dma_addr, phy_ring_head, phy_ring_tail;
>  	int cnt = eth->soc->dma_ring_size;
> -	dma_addr_t dma_addr;
>  	int i;
>  
>  	eth->scratch_ring = dma_alloc_coherent(eth->dev,
> -- 
> 2.14.3

Attachment: signature.asc
Description: PGP signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux