On Tue, Feb 15, 2011 at 11:13:52AM +0100, Roland Vossen wrote: > + rc = rc || wl_ucode_init_buf(wl, (void **)&bcm43xx_bomminor, > + D11UCODE_OVERSIGHT_BOMMINOR); > + return rc; This returns 0 on success and 1 on failure. Kernel style is to return negative error codes. The caller doesn't use the error code so maybe it's OK, but it seems ugly to me. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
