RE: [PATCH 1/4] brcm80211: fix compile issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Stanislav Fomichev [mailto:kernel@xxxxxxxxxxx]
> Sent: Monday, February 14, 2011 2:05 PM
> To: devel@xxxxxxxxxxxxxxxxxxxxxx
> Cc: Arend Van Spriel; Brett Rudley; Roland Vossen
> Subject: [PATCH 1/4] brcm80211: fix compile issue
> 
>     Commit dbd2fd656f2060abfd3a16257f8b51ec60f6d2ed changed the
>     definition of ieee80211_channel_to_frequency; so fix its usage in
> brcmfmac.
> 
> Signed-off-by: Stanislav Fomichev <kernel@xxxxxxxxxxx>
> ---
>  drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
> b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
> index fa2316b..cc4cf83 100644
> --- a/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
> +++ b/drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c
> @@ -2312,7 +2312,9 @@ static s32 wl_inform_single_bss(struct wl_priv *wl,
> struct wl_bss_info *bi)
>  	notif_bss_info->frame_len =
>  	    offsetof(struct ieee80211_mgmt,
>  		     u.beacon.variable) + wl_get_ielen(wl);
> -	freq = ieee80211_channel_to_frequency(notif_bss_info->channel);
> +	freq = ieee80211_channel_to_frequency(notif_bss_info->channel,
> +					      IEEE80211_BAND_2GHZ);
> +
>  	channel = ieee80211_get_channel(wiphy, freq);
> 
>  	WL_DBG("SSID : \"%s\", rssi %d, channel %d, capability : 0x04%x,
> bssid %pM\n",
> --
> 1.7.1
> 

Hard coding 2.4 Ghz to always be the band for channel_to_freq translations seems very wrong.  

Thanks
brett

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux