Re: [PATCH 00/30] staging: mt7621-mmc: Next cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Apr 29 2018, Christian Lütke-Stetzkamp wrote:

> Here are the next cleanups for the mt7621-mmc driver. It contains the
> removal of some unused things, the removal of the non DMA code and
> always using linked DMA mode together with some minor cleanups.

Thanks for these.
As mentioned separately I found one bug, but the relevant code becomes
inactive and can now be removed.
I'm happy for this to go in as-is with a couple of fix-ups to come in
the next batch.

I've tested and I can still access my sd card with no apparent issues.

 Reviewed-by: NeilBrown <neil@xxxxxxxxxx>
 
Thanks,
NeilBrown


>
> Christian Lütke-Stetzkamp (30):
>   staging: mt7621-mmc: Fix typo in function parameters
>   staging: mt7621-mmc: Remove unused field cmd_edge from msdc_hw
>   staging: mt7621-mmc: Remove unused field data_edge from msdc_hw
>   staging: mt7621-mmc: Remove unused field dat_drv from msdc_hw
>   staging: mt7621-mmc: Remove unused field cmd_drv from msdc_hw
>   staging: mt7621-mmc: Remove unused field clk_drv from msdc_hw
>   staging: mt7621-mmc: Remove unused macro msdc_init_gpd_ex
>   staging: mt7621-mmc: Remove unused macros sdr_{read,write}16
>   staging: mt7621-mmc: Remove function uffs
>   staging: mt7621-mmc: Replace macro sdr_set_field with function
>   staging: mt7621-mmc: Replace macro sdr_get_field with function
>   staging: mt7621-mmc: Remove unused static msdc_regs
>   staging: mt7621-mmc: Remove transfer mode setting from proc
>   staging: mt7621-mmc: Remove transfer mode setting variable
>   staging: mt7621-mmc: Remove unused global dma_size
>   staging: mt7621-mmc: Remove non-DMA transfer code
>   staging: mt7621-mmc: Remove unused variable dma_xfer from msdc_host
>   staging: mt7621-mmc: Fix error number assignment
>   staging: mt7621-mmc: Remove unused field abort from msdc_host
>   staging: mt7621-mmc: Remove unused sdio irq code
>   staging: mt7621-mmc: Do not BUG() if mrq set in msdc_ops_request
>   staging: mt7621-mmc: Remove redundant check for card status
>   staging: mt7621-mmc: Remove initialisation in msdc_dma_config
>   staging: mt7621-mmc: Inline function msdc_set_blknum
>   staging: mt7621-mmc: Don't disables DMA
>   staging: mt7621-mmc: Change return value of msdc_dma_config to void
>   staging: mt7621-mmc: Always use linked DMA mode
>   staging: mt7621-mmc: Remove unused macro HOST_MAX_NUM
>   staging: mt7621-mmc: Cleanup includes
>   staging: mt7621-mmc: Remove unused barrier macros
>
>  drivers/staging/mt7621-mmc/board.h     |   7 -
>  drivers/staging/mt7621-mmc/dbg.c       |  38 ---
>  drivers/staging/mt7621-mmc/dbg.h       |   3 -
>  drivers/staging/mt7621-mmc/mt6575_sd.h |  60 +----
>  drivers/staging/mt7621-mmc/sd.c        | 479 ++++++---------------------------
>  5 files changed, 96 insertions(+), 491 deletions(-)
>
> -- 
> 2.16.1

Attachment: signature.asc
Description: PGP signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux