On Thu, Apr 26, 2018 at 10:55:42AM +0200, Greg KH wrote:
> On Thu, Apr 26, 2018 at 10:35:52AM +0200, Sergio Paracuellos wrote:
> > On Thu, Apr 26, 2018 at 09:17:08AM +0200, Greg KH wrote:
> > > On Wed, Apr 25, 2018 at 04:01:40PM +0200, Sergio Paracuellos wrote:
> > > > It's good to have SPDX identifiers in all files to make it easier to
> > > > audit the kernel tree for correct licenses.
> > > >
> > > > Fix up the all of the staging ks7010 files to have a proper SPDX
> > > > identifier, based on the license text in the file itself. The SPDX
> > > > identifier is a legally binding shorthand, which can be used instead of
> > > > the full boiler plate text.
> > > >
> > > > Extra GPL text wording can be removed as it is no longer needed at all.
> > > >
> > > > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>
> > > > ---
> > > > drivers/staging/ks7010/ks7010_sdio.c | 5 +----
> > > > drivers/staging/ks7010/ks7010_sdio.h | 5 +----
> > > > drivers/staging/ks7010/ks_hostif.c | 5 +----
> > > > drivers/staging/ks7010/ks_hostif.h | 5 +----
> > > > drivers/staging/ks7010/ks_wlan.h | 5 +----
> > > > drivers/staging/ks7010/ks_wlan_ioctl.h | 5 +----
> > > > drivers/staging/ks7010/ks_wlan_net.c | 5 +----
> > > > drivers/staging/ks7010/michael_mic.c | 5 +----
> > > > drivers/staging/ks7010/michael_mic.h | 5 +----
> > > > 9 files changed, 9 insertions(+), 36 deletions(-)
> > > >
> > > > diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> > > > index b29f48c..b6cabab 100644
> > > > --- a/drivers/staging/ks7010/ks7010_sdio.c
> > > > +++ b/drivers/staging/ks7010/ks7010_sdio.c
> > > > @@ -1,13 +1,10 @@
> > > > +/* SPDX-License-Identifier: GPL-2.0 */
> > >
> > > {sigh}
> > >
> > > No, please read the documentation for how to do this correctly. You
> > > used the wrong comment marker for this :(
> >
> > ack! Sorry Greg. It seems that I have to use '//' comments in source files.
>
> For .c files, yes, for .h files, no. Please read the documentation
> well.
Yes, that's what I wanted to say, I have to be more explicit :)
>
> greg k-h
Thanks,
Sergio Paracuellos
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
