Re: [PATCH 1/5] ath6kl: address coding style with indent -linux -l 80 -lc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 11, 2011 at 01:21:35PM +0300, Dan Carpenter wrote:
> On Fri, Feb 11, 2011 at 01:27:15AM -0800, Luis R. Rodriguez wrote:
> > +		       address = mboxAddress[ENDPOINT1];
> > +		       status =
> > +		       HIFReadWrite(device, address, buffer, length,
> > +				    HIF_RD_SYNC_BYTE_INC, NULL); if (status) {
> > +		       AR_DEBUG_PRINTF(ATH_DEBUG_ERR,
> > +				       ("Unable to read the BMI data from the device\n"));
> > +		       return A_ERROR;}
> > +
> > +		       return 0;}

That's horrible, and it's why I don't take wholesale Lindent rework
patches.

Sorry Luis, you are going to have to do this "by hand".  Or run Lindent
and then clean it up by hand on your own, but I don't want to see the
code get mashed up like this for no good reason.

So I can't take this series.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux