On Tue, Apr 24, 2018 at 02:35:50AM +0200, Kirill Marinushkin wrote: > On 04/23/18 15:50, Greg Kroah-Hartman wrote: > > On Tue, Apr 17, 2018 at 07:00:28AM +0200, Kirill Marinushkin wrote: > >> In the current implementation, vchi_instance is inited during the first > >> call of bcm2835_audio_open_connection(), and is never freed. It causes a > >> memory leak when the module `snd_bcm2835` is removed. > >> > >> Here is how this commit fixes it: > >> > >> * the VCHI context (including vchi_instance) is created once in the > >> platform's devres > >> * the VCHI context is allocated and connected once during module_init() > >> * all created bcm2835_chips have a pointer to this VCHI context > >> * bcm2835_audio_open_connection() can access the VCHI context through the > >> associated bcm2835_chip > >> * the VCHI context is disconnected and freed once during module_exit() > >> > >> After this commit is applied, I don't see other issues with the module's > >> init/exit, so I also remove the associated TODO task. > >> > >> Steps to reproduce the memory leak before this commit: > > <snip> > > > > Patch dropped due to kbuild complaints. > > > > Please fix up and resend. > > > > thanks, > > > > greg k-h > > Hello Greg, > > Due to which complains of kbuild is the patch dropped? > I would like to fix the complains, but I don't see any errors or warnings on my > side. > Are you sure that the kbuild test robot did it's job correctly? The log says: > > >> it may well be a FALSE warning > > Please show me what is wrong in my patch. I have no idea as the patch is long gone from my queue now. If you think all is fine, please resend it and I will be glad to review it again. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
