Re: [PATCH 04/11] staging: vchiq_arm: Clear VLA warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 04, 2018 at 09:25:54PM +0200, Stefan Wahren wrote:
> 
> > kbuild test robot <lkp@xxxxxxxxx> hat am 1. April 2018 um 01:36 geschrieben:
> > 
> > 
> > Hi Stefan,
> > 
> > I love your patch! Perhaps something to improve:
> > 
> > [auto build test WARNING on staging/staging-testing]
> > [also build test WARNING on v4.16-rc7 next-20180329]
> > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> > 
> > url:    https://github.com/0day-ci/linux/commits/Stefan-Wahren/staging-vchiq_core-Fix-missing-semaphore-release-in-error-case/20180401-055855
> > config: ia64-allmodconfig (attached as .config)
> > compiler: ia64-linux-gcc (GCC) 7.2.0
> > reproduce:
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # save the attached .config to linux build tree
> >         make.cross ARCH=ia64 
> > 
> > All warnings (new ones prefixed by >>):
> > 
> >    In file included from include/linux/printk.h:7:0,
> >                     from include/linux/kernel.h:14,
> >                     from drivers/staging//vc04_services/interface/vchiq_arm/vchiq_arm.c:35:
> >    drivers/staging//vc04_services/interface/vchiq_arm/vchiq_arm.c: In function 'vchiq_dump_service_use_state':
> >    include/linux/kern_levels.h:5:18: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long unsigned int' [-Wformat=]
> >     #define KERN_SOH "\001"  /* ASCII Start Of Header */
> >                      ^
> >    include/linux/kern_levels.h:14:19: note: in expansion of macro 'KERN_SOH'
> >     #define KERN_INFO KERN_SOH "6" /* informational */
> >                       ^~~~~~~~
> >    drivers/staging//vc04_services/interface/vchiq_arm/vchiq_core.h:52:28: note: in expansion of macro 'KERN_INFO'
> >     #define VCHIQ_LOG_PREFIX   KERN_INFO "vchiq: "
> >                                ^~~~~~~~~
> >    drivers/staging//vc04_services/interface/vchiq_arm/vchiq_core.h:62:11: note: in expansion of macro 'VCHIQ_LOG_PREFIX'
> >        printk(VCHIQ_LOG_PREFIX fmt "\n", ##__VA_ARGS__); } while (0)
> >               ^~~~~~~~~~~~~~~~
> > >> drivers/staging//vc04_services/interface/vchiq_arm/vchiq_arm.c:3479:3: note: in expansion of macro 'vchiq_log_warning'
> >       vchiq_log_warning(vchiq_susp_log_level, "Too many active "
> >       ^~~~~~~~~~~~~~~~~
> >    drivers/staging//vc04_services/interface/vchiq_arm/vchiq_arm.c:3480:47: note: format string is defined here
> >        "services (%d).  Only dumping up to first %d services "
> >                                                  ~^
> >                                                  %ld
> > 
> 
> Sorry, i will fix that in the next round.

Ok, I've applied some patches in this series, please fix up and rebase
and resend the remaining ones.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux