To be honest, it wasn't even the right thing for me to comment this patch. If you think it makes the code nicer then go ahead, you've earned that. The patchset is nice and makes a bunch of tricky improvements to the code. I reviewed it pretty carefully and couldn't find any new bugs. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel