Re: [PATCH 1/2] staging: fsl-dpaa2/rtc: add rtc driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yangbo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on staging/staging-testing]
[also build test ERROR on v4.17-rc1 next-20180420]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Yangbo-Lu/staging-fsl-dpaa2-rtc-add-rtc-driver/20180420-190320
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

>> drivers/staging/fsl-dpaa2/rtc/rtc.c:130:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
     .gettime64 = ptp_dpaa2_gettime,
                  ^~~~~~~~~~~~~~~~~
   drivers/staging/fsl-dpaa2/rtc/rtc.c:130:15: note: (near initialization for 'ptp_dpaa2_caps.gettime64')
   drivers/staging/fsl-dpaa2/rtc/rtc.c:131:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
     .settime64 = ptp_dpaa2_settime,
                  ^~~~~~~~~~~~~~~~~
   drivers/staging/fsl-dpaa2/rtc/rtc.c:131:15: note: (near initialization for 'ptp_dpaa2_caps.settime64')
   cc1: some warnings being treated as errors

vim +130 drivers/staging/fsl-dpaa2/rtc/rtc.c

   118	
   119	static struct ptp_clock_info ptp_dpaa2_caps = {
   120		.owner		= THIS_MODULE,
   121		.name		= "DPAA2 PTP Clock",
   122		.max_adj	= 512000,
   123		.n_alarm	= 2,
   124		.n_ext_ts	= 2,
   125		.n_per_out	= 3,
   126		.n_pins		= 0,
   127		.pps		= 1,
   128		.adjfreq	= ptp_dpaa2_adjfreq,
   129		.adjtime	= ptp_dpaa2_adjtime,
 > 130		.gettime64	= ptp_dpaa2_gettime,
   131		.settime64	= ptp_dpaa2_settime,
   132	};
   133	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux