On Thu, Apr 19, 2018 at 10:41:15AM +0200, Linus Walleij wrote: > To make sure that these drivers do not leave staging before they > are properly converted to use the new GPIO descriptor API, and the > GPIOLIB_IRQCHIP helper library, create the TODO file with these work > items. > > Cc: Johan Hovold <johan@xxxxxxxxxx> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Thanks for documenting this in the tree. This code had to run on old Android kernels so we could not use fancy things like gpio descriptors and the gpio-irqchip implementation at the time. ;) > --- > I started some work in this area, make sure to just throw me in > on CC whenever anyone works on it and I will happily help and > provide examples! > --- > drivers/staging/greybus/TODO | 5 +++++ > 1 file changed, 5 insertions(+) > create mode 100644 drivers/staging/greybus/TODO > > diff --git a/drivers/staging/greybus/TODO b/drivers/staging/greybus/TODO > new file mode 100644 > index 000000000000..3b90a5711998 > --- /dev/null > +++ b/drivers/staging/greybus/TODO > @@ -0,0 +1,5 @@ > +* Convert all uses of the old GPIO API from <linux/gpio.h> to the > + GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO > + lines from device tree or ACPI. Not sure that this sentence makes sense for greybus however. We're querying the module about how many lines it provides using the greybus protocol, and while we had some ideas about moving some such descriptions to device-tree fragments (which we'd retrieve from the module instead) that's probably not going to happen for a while. The chance of ACPI being used for this is nil in any case. > +* Convert the GPIO driver to use the GPIO irqchip library > + GPIOLIB_IRQCHIP instead of reimplementing the same. Thanks, Johan _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
