> From: Vasiliy Kulikov [mailto:segoon@xxxxxxxxxxxx] > Sent: Thursday, February 10, 2011 11:01 AM > > obj is not freed if __get_free_page() failed. > > Signed-off-by: Vasiliy Kulikov <segoon@xxxxxxxxxxxx> Thanks Vasiliy! Good catch! > drivers/staging/zcache/zcache.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/zcache/zcache.c > b/drivers/staging/zcache/zcache.c > index 61be849..b8a2b30 100644 > --- a/drivers/staging/zcache/zcache.c > +++ b/drivers/staging/zcache/zcache.c > @@ -790,6 +790,7 @@ static int zcache_do_preload(struct tmem_pool > *pool) > page = (void *)__get_free_page(ZCACHE_GFP_MASK); > if (unlikely(page == NULL)) { > zcache_failed_get_free_pages++; > + kmem_cache_free(zcache_obj_cache, obj); > goto unlock_out; > } > preempt_disable(); Acked-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx> _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
