The ext_power_on|off fields of msdc_hw are never set, and only once checked for not being zero, so they can just be removed. Signed-off-by: Christian Lütke-Stetzkamp <christian@xxxxxxxx> --- drivers/staging/mt7621-mmc/board.h | 4 ---- drivers/staging/mt7621-mmc/sd.c | 10 ++-------- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging/mt7621-mmc/board.h b/drivers/staging/mt7621-mmc/board.h index c4e014d01635..a60347cd3da8 100644 --- a/drivers/staging/mt7621-mmc/board.h +++ b/drivers/staging/mt7621-mmc/board.h @@ -64,10 +64,6 @@ struct msdc_hw { /* config gpio pull mode */ void (*config_gpio_pin)(int type, int pull); - - /* external power control for card */ - void (*ext_power_on)(void); - void (*ext_power_off)(void); }; extern struct msdc_hw msdc0_hw; diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c index eaf2e56abb29..78043b267a65 100644 --- a/drivers/staging/mt7621-mmc/sd.c +++ b/drivers/staging/mt7621-mmc/sd.c @@ -771,16 +771,10 @@ static void msdc_card_power(struct msdc_host *host, int on) if (on) { msdc_pin_config(host, MSDC_PIN_PULL_UP); - if (host->hw->ext_power_on) - host->hw->ext_power_on(); - //else - //msdc_vdd_on(host); // need todo card detection. + //msdc_vdd_on(host); // need todo card detection. msleep(1); } else { - if (host->hw->ext_power_off) - host->hw->ext_power_off(); - //else - //msdc_vdd_off(host); + //msdc_vdd_off(host); msdc_pin_config(host, MSDC_PIN_PULL_DOWN); msleep(1); } -- 2.16.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel