> + case 3: { > + if (0 != write_saa(p, 0x02, 0x80)) { > + SAY("ERROR: failed to set SAA register 0x02 " > + " for input %i\n", input); ^ > + } I only point that out to show I'm paying attention, I don't really care. You can fix it later... All three patches look good. Reviewed-by: Dan Carpenter <error27@xxxxxxxxx> regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel