On Fri, Apr 06, 2018 at 10:36:57AM +0200, Christian Lütke-Stetzkamp wrote:
> If the debug file in proc fs is not successfully created current code
> prints an error message, this is removed.
>
> Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Christian Lütke-Stetzkamp <christian@xxxxxxxx>
> ---
> drivers/staging/mt7621-mmc/dbg.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/mt7621-mmc/dbg.c b/drivers/staging/mt7621-mmc/dbg.c
> index abf92a84a417..9ad330729300 100644
> --- a/drivers/staging/mt7621-mmc/dbg.c
> +++ b/drivers/staging/mt7621-mmc/dbg.c
> @@ -340,10 +340,6 @@ static const struct file_operations msdc_debug_fops = {
> int msdc_debug_proc_init(void)
> {
> struct proc_dir_entry *de = proc_create("msdc_debug", 0667, NULL, &msdc_debug_fops);
> -
> - if (!de || IS_ERR(de))
> - printk("!! Create MSDC debug PROC fail !!\n");
> -
The warning is that the IS_ERR() can be removed... You can remove the
NULL check too though, I don't care. But then, please remove the whole
"struct proc_dir_entry *de = " assignment as well?
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
