On Thu, Apr 05, 2018 at 03:13:10PM +0300, Dan Carpenter wrote: > [ I just decided to forward you guys all the Smatch warnings. -dan ] > > Hello John Crispin, > > The patch 8b634a9c7620: "staging: mt7621-mmc: MIPS: ralink: add sdhci > for mt7620a SoC" from Mar 15, 2018, leads to the following static > checker warning: > > drivers/staging/mt7621-mmc/sd.c:951 msdc_command_start() > warn: we tested 'opcode == 3' before and it was 'false' > > drivers/staging/mt7621-mmc/sd.c:2961 msdc_drv_suspend() > warn: variable dereferenced before check 'mmc' (see line 2959) > > drivers/staging/mt7621-mmc/sd.c:2976 msdc_drv_resume() > warn: variable dereferenced before check 'mmc' (see line 2972) > > drivers/staging/mt7621-mmc/dbg.c:270 msdc_debug_proc_write() > warn: copy_to/from_user() returns a positive value > > drivers/staging/mt7621-mmc/dbg.c:339 msdc_debug_proc_init() > warn: proc file '"msdc_debug"' is world writable > > drivers/staging/mt7621-mmc/dbg.c:341 msdc_debug_proc_init() > warn: 'de' isn't an ERR_PTR Hi Dan, thanks for the report, I have created patches for all of these and will send them, once my previous series got merged, because I based them on that status. Christian _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
