Re: [PATCH v2 00/34] staging: mt7621-mmc: First cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 04 2018, Christian Lütke-Stetzkamp wrote:

> This patch series does the first cleanups in this driver. At some
> points I already tried to get the code of this driver as near as
> possible to the mk-sd driver in mainline.
>
> Changes in v2:
> * fix typos
> * Clearify comment regarding request irq

Thanks,
 It compiles and works for me, and the patches look good.

 Reviewed-by: NeilBrown <neil@xxxxxxxxxx>

There are two new warnings as msdc_eirq_cd and msdc_eirq_sdio are now
unused.  I think they should be discarded - they don't contain any
insights into how the hardware might work, and they are clearly untested
so possibly buggy.

Thanks,
NeilBrown


>
> Christian Lütke-Stetzkamp (34):
>   staging: mt7621-mmc: Remove whitespace errors in board.h
>   staging: mt7621-mmc: Remove whitespace errors in dbg.c
>   staging: mt7621-mmc: Remove whitespace errors in dbg.h
>   staging: mt7621-mmc: Remove whitespace errors in mt6575_sd.h
>   staging: mt7621-mmc: Remove whitespace errors in sd.c
>   staging: mt7621-mmc: Fix indent for dbg.c
>   staging: mt7621-mmc: Fix indent for board.h
>   staging: mt7621-mmc: Fix indent for dbg.h
>   staging: mt7621-mmc: Fix indent for mt6575_sd.h
>   staging: mt7621-mmc: Fix indent for sd.c
>   staging: mt7621-mmc: Fix spacing
>   staging: mt7621-mmc: Fix Pointer Location
>   staging: mt7621-mmc: Remove unnecessary typedefs
>   staging: mt7621-mmc: Fix trailing statements
>   staging: mt7621-mmc: Remove global initialise to 0
>   staging: mt7621-mmc: Fix style of braces
>   staging: mt7621-mmc: Remove redundant driver owner assignment
>   staging: mt7621-mmc: Replace seq_printf with seq_puts where possible
>   staging: mt7621-mmc: Remove code guarded by nonexistent config option
>   staging: mt7621-mmc: Remove code for different soc types
>   staging: mt7621-mmc: Remove unused datastructures
>   staging: mt7621-mmc: Cleanup function mt_msdc_init
>   staging: mt7621-mmc: Refactor suspend, resume
>   staging: mt7621-mmc: Fix memory leek in case of error in probe
>   staging: mt7621-mmc: Remove code checking for old kernel versions
>   staging: mt7621-mmc: Fix unmatched release_mem_regin
>   staging: mt7621-mmc: Fix bug on dma_alloc_coherent fail
>   staging: mt7621-mmc: Remove unnecessary setting of dev.platform_data
>   staging: mt7621-mmc: Remove unnecessary field from struct msdc_hw
>   staging: mt7621-mmc: Fix different caps for different devices
>   staging: mt7621-mmc: Remove dead codepath from probe function
>   staging: mt7621-mmc: Fix dma_alloc_coherent should get device as first
>     param
>   staging: mt7621-mmc: Fix requesting of irq
>   staging: mt7621-mmc: Remove duplicate defines
>
>  drivers/staging/mt7621-mmc/board.h     |   75 +-
>  drivers/staging/mt7621-mmc/dbg.c       |  389 +--
>  drivers/staging/mt7621-mmc/dbg.h       |   98 +-
>  drivers/staging/mt7621-mmc/mt6575_sd.h | 1104 ++++----
>  drivers/staging/mt7621-mmc/sd.c        | 4689 ++++++++++++++++----------------
>  5 files changed, 3146 insertions(+), 3209 deletions(-)
>
> -- 
> 2.16.1

Attachment: signature.asc
Description: PGP signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux